-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(tabset): lazy loading #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
6ddc5c8
fix(tabset): lazy load
evtkhvch 5a99e0a
ref(tabset): extract view logic
evtkhvch 3eee78f
ref(tabset): turn activeValue into active
evtkhvch 2a32b46
ref(tabset): made init property deprecated
evtkhvch 9aac907
chore(NbTabComponent): init property description
evtkhvch 6579461
style(tabset): add new lines
evtkhvch 64277e1
fix(tabset): remove portal implementation
evtkhvch aa4b804
fix(tabset): remove portal import
evtkhvch 183494f
fix(tabset): module imports
evtkhvch b1b779d
style(tabset): rename variable
evtkhvch 3e736ce
fix(tabset): add template outlet
evtkhvch eb1bc77
style(tabset): remove comments
evtkhvch 7621f86
fix(tabset): add wrap container
evtkhvch 9a0e959
style(tabset): add new line
evtkhvch 87bf2cb
fix(tabset): change lazy directive
evtkhvch 868eb82
fix(tabset): add getter for lazy template
evtkhvch 1aa9b6f
fix(tabset): remove getter
evtkhvch 0c8f1ed
Merge branch 'master' into 1827-fix-lazy-tab-component
yggg bc2990b
Merge branch 'master' into 1827-fix-lazy-tab-component
yggg cb4aff7
Merge remote-tracking branch 'origin/master' into 1827-fix-lazy-tab-c…
evtkhvch 8cbeeda
fix(tabset): add lazy content directive to public api
evtkhvch a3ba8f6
Merge branch 'master' into 1827-fix-lazy-tab-component
yggg 27f58a0
refactor(tabset): rename lazy content directive
yggg feee75a
style(tabset): remove redundant comment
yggg 4810ac1
style(tabset): update deprecation comments
yggg 1727213
refactor(tabset): remove redundant accessors
yggg 90631dc
refactor(tabset): use a single ng-container
yggg 0f4b2d5
docs(tabset): hide deprecated properties
yggg a241628
docs(tabset): add nbTabContent usage example
yggg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
src/framework/theme/components/tabset/tab-content.directive.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { Directive, TemplateRef } from '@angular/core'; | ||
|
||
/** | ||
* Directive to wrap tab lazy content. | ||
* */ | ||
@Directive({ | ||
selector: '[nbTabContent]', | ||
}) | ||
export class NbTabContentDirective { | ||
constructor(public templateRef: TemplateRef<any>) {} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.