-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support strict template check #2273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incompatible with strictTemplates mode
Incompatible with strictTemplates mode
Also adds ability to use as a boolean attribute
BREAKING CHANGE: Generic value type removed from NbSelectComponent
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #2273 +/- ##
==========================================
- Coverage 81.65% 81.55% -0.10%
==========================================
Files 244 244
Lines 7359 7369 +10
Branches 771 773 +2
==========================================
+ Hits 6009 6010 +1
- Misses 1122 1131 +9
Partials 228 228
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fixes #2263, Fixes #2247 and #2221 (comment)
BREAKING CHANGE:
Generic value type removed from NbSelectComponent