Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support strict template check #2273

Merged
merged 27 commits into from
Mar 13, 2020
Merged

fix: support strict template check #2273

merged 27 commits into from
Mar 13, 2020

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Mar 13, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #2263, Fixes #2247 and #2221 (comment)

BREAKING CHANGE:
Generic value type removed from NbSelectComponent

yggg added 27 commits March 12, 2020 13:49
Incompatible with strictTemplates mode
Incompatible with strictTemplates mode
Also adds ability to use as a boolean attribute
BREAKING CHANGE:
Generic value type removed from NbSelectComponent
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #2273 into master will decrease coverage by 0.09%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##           master    #2273      +/-   ##
==========================================
- Coverage   81.65%   81.55%   -0.10%     
==========================================
  Files         244      244              
  Lines        7359     7369      +10     
  Branches      771      773       +2     
==========================================
+ Hits         6009     6010       +1     
- Misses       1122     1131       +9     
  Partials      228      228              
Impacted Files Coverage Δ
...e/components/accordion/accordion-item.component.ts 30.95% <ø> (ø)
.../theme/components/accordion/accordion.component.ts 41.66% <ø> (ø)
...work/theme/components/actions/actions.component.ts 100.00% <ø> (ø)
...ramework/theme/components/alert/alert.component.ts 92.95% <ø> (ø)
...mework/theme/components/button/button.component.ts 87.05% <ø> (ø)
...calendar-day-picker/calendar-day-cell.component.ts 94.44% <ø> (ø)
...lendar-day-picker/calendar-day-picker.component.ts 100.00% <ø> (ø)
...lendar-days-names/calendar-days-names.component.ts 94.11% <ø> (ø)
...ndar-month-picker/calendar-month-cell.component.ts 93.75% <ø> (ø)
...ar-month-picker/calendar-month-picker.component.ts 83.87% <ø> (ø)
... and 44 more

@yggg yggg merged commit 9b4ff5b into akveo:master Mar 13, 2020
@yggg yggg deleted the fix/support-strict-template-check branch March 13, 2020 15:38
@yggg yggg mentioned this pull request Mar 16, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoComplete wrong access modifiers? 'get' and 'set' accessor must have the same type.
1 participant