Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click trigger memory leak #907

Closed
nnixaa opened this issue Oct 15, 2018 · 0 comments
Closed

Click trigger memory leak #907

nnixaa opened this issue Oct 15, 2018 · 0 comments
Assignees
@nnixaa
Labels
module:theme P1: urgent

Comments

@nnixaa
Copy link
Collaborator

nnixaa commented Oct 15, 2018

we need to unsubscribe from the click subscription of the trigger
@issue-sh issue-sh bot added In Progress and removed Sprint labels Oct 16, 2018
nnixaa added a commit that referenced this issue Oct 16, 2018
@nnixaa
fix(overlay): fix click trigger
3a89b69 
Closes #907
@nnixaa nnixaa mentioned this issue Oct 16, 2018
Merged
@issue-sh issue-sh bot added In Review and removed In Progress labels Oct 16, 2018
@issue-sh issue-sh bot removed the In Review label Oct 16, 2018
nnixaa added a commit that referenced this issue Oct 16, 2018
@nnixaa
fix(overlay): fix click trigger (#912)
08c2eb6 
Closes #907
@issue-sh issue-sh bot reopened this Oct 17, 2018
@issue-sh issue-sh bot closed this as completed Oct 17, 2018
@issue-sh issue-sh bot removed the Done In Sprint label Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nnixaa nnixaa

Labels
module:theme P1: urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nnixaa