fix(auth): don't import http module (#919)

Closes #631
akveo · Oct 22, 2018 · 995de58 · 995de58
1 parent 57fda28
commit 995de58
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/docs/articles/auth-install.md b/docs/articles/auth-install.md
@@ -17,6 +17,24 @@ npm i @nebular/auth
 ```
 <hr>
 
+## HttpClientModule
+
+Auth module utilizes features of `HttpClientModule` and since it should only be imported in the root module, please make sure you've done this:
+
+```ts
+import { HttpClientModule } from '@angular/common/http';
+
+// ...
+
+@NgModule({
+  imports: [
+    HttpClientModule
+  ],
+})
+export class AppModule {
+
+```
+
 ## Import
 
 Import the module and `NbPasswordAuthStrategy` strategy:

diff --git a/src/framework/auth/auth.module.ts b/src/framework/auth/auth.module.ts
@@ -2,7 +2,7 @@ import { Injector, ModuleWithProviders, NgModule } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { RouterModule } from '@angular/router';
 import { FormsModule } from '@angular/forms';
-import { HttpClientModule, HttpRequest } from '@angular/common/http';
+import { HttpRequest } from '@angular/common/http';
 
 import {
   NbAlertModule,
@@ -95,7 +95,6 @@ export function nbNoOpInterceptorFilter(req: HttpRequest<any>): boolean {
     NbButtonModule,
     RouterModule.forChild(routes),
     FormsModule,
-    HttpClientModule,
   ],
   declarations: [
     NbAuthComponent,