Issue 172: Delete CodeController.theme, bump version to 0.3.0 #247
+6
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeyinkin
suggested changes
Jun 7, 2023
CHANGELOG.md
Outdated
Comment on lines
1
to
3
| ## 0.3.0 | ||
| * **BREAKING:** Deleted `CodeController.stringMap`. | ||
| * **BREAKING:** Deleted `theme` from `CodeController`, (Issue [172](https://github.com/akvelon/flutter-code-editor/issues/172)). |
There was a problem hiding this comment.
Suggested change
| ## 0.3.0 | |
| * **BREAKING:** Deleted `CodeController.stringMap`. | |
| * **BREAKING:** Deleted `theme` from `CodeController`, (Issue [172](https://github.com/akvelon/flutter-code-editor/issues/172)). | |
| ## 0.3.0 | |
| * **BREAKING:** Deleted `CodeController.stringMap`. | |
| * **BREAKING:** Deleted `CodeController.theme`, (Issue [172](https://github.com/akvelon/flutter-code-editor/issues/172)). |
Comment on lines
902
to
906
| // This check is disabled, because _processPatterns | ||
| // breaks emoji display and is was not useful. | ||
| // if (_styleRegExp != null) { | ||
| // return _processPatterns(text, style); | ||
| // } |
Comment on lines
911
to
943
| // TextSpan _processPatterns(String text, TextStyle? style) { | ||
| // final children = <TextSpan>[]; | ||
|
|
||
| // text.splitMapJoin( | ||
| // _styleRegExp!, | ||
| // onMatch: (Match m) { | ||
| // if (_styleList.isEmpty) { | ||
| // return ''; | ||
| // } | ||
|
|
||
| // int idx; | ||
| // for (idx = 1; | ||
| // idx < m.groupCount && | ||
| // idx <= _styleList.length && | ||
| // m.group(idx) == null; | ||
| // idx++) {} | ||
|
|
||
| // children.add( | ||
| // TextSpan( | ||
| // text: m[0], | ||
| // style: _styleList[idx - 1], | ||
| // ), | ||
| // ); | ||
| // return ''; | ||
| // }, | ||
| // onNonMatch: (String span) { | ||
| // children.add(TextSpan(text: span, style: style)); | ||
| // return ''; | ||
| // }, | ||
| // ); | ||
|
|
||
| // return TextSpan(style: style, children: children); | ||
| // } |
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 81.96% 82.50% +0.54%
==========================================
Files 107 107
Lines 3166 3144 -22
==========================================
- Hits 2595 2594 -1
+ Misses 571 550 -21
|
alexeyinkin
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted
CodeController.stringMap.Resolves #172