Add Custom Search (CTRL + F) #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 80.93% 81.96% +1.02%
==========================================
Files 88 107 +19
Lines 2728 3166 +438
==========================================
+ Hits 2208 2595 +387
- Misses 520 571 +51
|
alexeyinkin
suggested changes
Apr 26, 2023
alexeyinkin
reviewed
Apr 26, 2023
alexeyinkin
suggested changes
Apr 27, 2023
alexeyinkin
reviewed
May 4, 2023
alexeyinkin
reviewed
May 4, 2023
alexeyinkin
reviewed
May 4, 2023
alexeyinkin
reviewed
May 5, 2023
| @@ -0,0 +1,12 @@ | |||
| import 'package:flutter/widgets.dart'; | |||
|
|
|||
| class IgnoreIntent extends Intent { | |||
There was a problem hiding this comment.
Can we use this one? https://api.flutter.dev/flutter/widgets/DoNothingIntent-class.html
alexeyinkin
reviewed
May 5, 2023
alexeyinkin
reviewed
May 5, 2023
| _processText(textAfter); | ||
| } | ||
| } else { | ||
| if (sliceIndex < 0 || sliceIndex > text.length) { |
There was a problem hiding this comment.
Suggested change
| if (sliceIndex < 0 || sliceIndex > text.length) { | |
| if (sliceIndex < 0 || sliceIndex >= text.length) { |
?
There was a problem hiding this comment.
If it is equal, we can call substring on it like 'a'.substring(0, 1);.
This is the range, that implies inability to substring the text.
There was a problem hiding this comment.
maybe I should add clarification comment?
alexeyinkin
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchController.isEnabledto better place #234