-
Notifications
You must be signed in to change notification settings - Fork 185
Fixed out-of-date ReadMe on "Editable Complex Components" #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you make seperate PRs to do different things? Also do you have any docs on the RNAppGlobals? I'd love to read up on it |
@iRoachie https://github.com/aksonov/react-native-tableview/blob/master/RNTableView/RNAppGlobals.m here you can see it's outdated. Also here you can see it's not needed for Complex Components anymore: #102 |
Oh i thought you meant something with react-native on their end |
@iRoachie Updated the PR to only contain the ReadMe update. |
@iRoachie Is this package still being maintained? |
Thanks @dylancom. I really don't have enough time to maintain it. But I also am not the admin so I can't assign a new maintainer. |
ReadMe on using "Editable Complex Components" is out-of-date.
It provides an unnecessary step on importing RNAppGlobals.
See: https://github.com/aksonov/react-native-tableview/blob/master/RNTableView/RNAppGlobals.m
And a PR that already made the importing unnecessary (but docs weren't updated):
#102