Skip to content

Fixed out-of-date ReadMe on "Editable Complex Components" #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 4, 2021

Conversation

dylancom
Copy link
Contributor

@dylancom dylancom commented Apr 9, 2020

ReadMe on using "Editable Complex Components" is out-of-date.
It provides an unnecessary step on importing RNAppGlobals.

See: https://github.com/aksonov/react-native-tableview/blob/master/RNTableView/RNAppGlobals.m

And a PR that already made the importing unnecessary (but docs weren't updated):
#102

@dylancom dylancom changed the title Update ReadMe as: RNAppGlobals is deprecated/no longer needed and will be removed soon Fixed out-of-date ReadMe and wrong font PropType. Apr 14, 2020
@iRoachie
Copy link
Collaborator

Can you make seperate PRs to do different things? Also do you have any docs on the RNAppGlobals? I'd love to read up on it

@dylancom
Copy link
Contributor Author

dylancom commented Apr 14, 2020

@iRoachie https://github.com/aksonov/react-native-tableview/blob/master/RNTableView/RNAppGlobals.m here you can see it's outdated.

Also here you can see it's not needed for Complex Components anymore: #102

@iRoachie
Copy link
Collaborator

Oh i thought you meant something with react-native on their end

This reverts commit 84be7d3.
This reverts commit c7d5c68.
@dylancom dylancom changed the title Fixed out-of-date ReadMe and wrong font PropType. Fixed out-of-date ReadMe on "Editable Complex Components" Apr 14, 2020
@dylancom
Copy link
Contributor Author

@iRoachie Updated the PR to only contain the ReadMe update.

@dylancom
Copy link
Contributor Author

@iRoachie Is this package still being maintained?

@iRoachie iRoachie merged commit da44f72 into aksonov:master Jan 4, 2021
@iRoachie
Copy link
Collaborator

iRoachie commented Jan 4, 2021

Thanks @dylancom. I really don't have enough time to maintain it. But I also am not the admin so I can't assign a new maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants