Skip to content

add Insert mode handling (UITableViewCellEditingStyleInsert)#185

Merged
iRoachie merged 3 commits intoaksonov:nextfrom
damikdk:handling-Insert-1
Sep 28, 2018
Merged

add Insert mode handling (UITableViewCellEditingStyleInsert)#185
iRoachie merged 3 commits intoaksonov:nextfrom
damikdk:handling-Insert-1

Conversation

@damikdk
Copy link
Contributor

@damikdk damikdk commented Aug 14, 2018

No description provided.

@iRoachie
Copy link
Collaborator

Can you explain your intention by making this change?

@damikdk
Copy link
Contributor Author

damikdk commented Aug 19, 2018

Of course. There is no way to handle pressing on plus sign (and row itself maybe) if tableViewCellEditingStyle == Insert, like here:

photo_2018-08-19_22-41-46

@damikdk
Copy link
Contributor Author

damikdk commented Aug 23, 2018

Any update, guys? I think, it's important

@iRoachie

@iRoachie
Copy link
Collaborator

Sorry about the wait, how would I be able to test if this works? Can you set up a quick example that I can test. Just want to make sure I don't break existing funcitonality

@damikdk
Copy link
Contributor Author

damikdk commented Aug 24, 2018

I added second TableView with tableViewCellEditingStyle={TableView.Consts.CellEditingStyle.Insert} to 'Example 6' screen. If it works, you will see this alert.

Now you can just run example project from my branch. Is it enough? :)

@damikdk
Copy link
Contributor Author

damikdk commented Aug 31, 2018

Sorry for annoying, but can I get some feedback on this PR? Thank you!

@iRoachie iRoachie changed the base branch from master to next September 28, 2018 04:32
@iRoachie iRoachie merged commit b22d927 into aksonov:next Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants