Skip to content

fix save_test_history macro to work when a model (snapshot or model) depends_on a source with the same name - #3

Merged
akshaykarle merged 2 commits into
akshaykarle:save-history-bug-fixesfrom
cmardiros:save-history-bug-fixes-snapshot-safe
Jun 22, 2023
Merged

akshaykarle merged 2 commits into
akshaykarle:save-history-bug-fixesfrom
cmardiros:save-history-bug-fixes-snapshot-safe

Conversation

@cmardiros

Copy link
Copy Markdown

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

@cmardiros
cmardiros changed the base branch from main to save-history-bug-fixes June 22, 2023 11:19
Comment thread macros/run_end/save_results_history.sql Outdated
@cmardiros cmardiros changed the title Extend Save history fixes to snapshots without snapshot in name fix save_test_history macro to work when a model (snapshot or model) depends_on a source with the same name Jun 22, 2023

@akshaykarle akshaykarle left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM

@akshaykarle
akshaykarle merged commit 4719c98 into akshaykarle:save-history-bug-fixes Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants