Merge pull request #1 from tokio-rs/eliza/humancalico/option

fix lifetime mismatch
akshatagarwl · Aug 5, 2020 · eefcfc0 · eefcfc0
2 parents 4996eb3 + afe04fd
commit eefcfc0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/tracing-core/src/field.rs b/tracing-core/src/field.rs
@@ -227,9 +227,9 @@ pub trait Visit {
     fn record_debug(&mut self, field: &Field, value: &dyn fmt::Debug);
 
     /// Visit an Option
-    fn record_option(&mut self, field: &Field, value: Option<&'static (dyn Value + 'static)>) {
+    fn record_option(&mut self, field: &Field, value: Option<&(dyn Value + 'static)>) {
         if let Some(inner_value) = value {
-            self.record_debug(field, &value)
+            self.record_debug(field, &inner_value)
         } else {
         }
     }
@@ -451,7 +451,7 @@ impl<'a> Value for fmt::Arguments<'a> {
 
 impl<T> Value for Option<T>
 where
-    T: Value,
+    T: Value + 'static,
 {
     fn record(&self, key: &Field, visitor: &mut dyn Visit) {
         visitor.record_option(key, self.as_ref().map(|v| v as &dyn Value))