feat: add a router for navigating between application views #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrutsko
reviewed
Aug 15, 2023
akrutsko
reviewed
Aug 15, 2023
valr0lipsk
approved these changes
Aug 15, 2023
akrutsko
reviewed
Aug 15, 2023
OreskaG
approved these changes
Aug 15, 2023
akrutsko
reviewed
Aug 15, 2023
akrutsko
reviewed
Aug 15, 2023
akrutsko
reviewed
Aug 15, 2023
akrutsko
reviewed
Aug 15, 2023
akrutsko
reviewed
Aug 15, 2023
Luchiweb
approved these changes
Aug 15, 2023
akrutsko
approved these changes
Aug 15, 2023
Luchiweb
pushed a commit
that referenced
this pull request
Aug 16, 2023
* feat: add class router * feat: merged with login-registration-main * feat: routing login/signup/main * refactor: change type of routes: Record<string, string> * refactor: change AS to instanceof * refactor: use foreach nstead of let i = 0... * feat: add laizy loading for routing views * feat: change main view for routing * feat: add 404 to main view and router * feat: add 404 to main view and router * refactor: remove unuser async * refactor: remove unuser async * refactor: remove unuser async * refactor: saparate list of routers * feat: add hashValue in router * feat: add hashValue in router * fix: sintax link ice-adventures * refactor: delete unused navigateToLogin * refactor: change click event on mouseover in header categories * refactor: change click event on mouseover in header categories
Luchiweb
pushed a commit
that referenced
this pull request
Aug 16, 2023
* feat: add class router * feat: merged with login-registration-main * feat: routing login/signup/main * refactor: change type of routes: Record<string, string> * refactor: change AS to instanceof * refactor: use foreach nstead of let i = 0... * feat: add laizy loading for routing views * feat: change main view for routing * feat: add 404 to main view and router * feat: add 404 to main view and router * refactor: remove unuser async * refactor: remove unuser async * refactor: remove unuser async * refactor: saparate list of routers * feat: add hashValue in router * feat: add hashValue in router * fix: sintax link ice-adventures * refactor: delete unused navigateToLogin * refactor: change click event on mouseover in header categories * refactor: change click event on mouseover in header categories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a router
Description of changes 🗣️
Create a Router class that captures the window.onpopstate events and manages the visibility of content in the SPA application
Related Tasks 🔗
Special Instructions for the Reviewers☝🏻
N/A
Additional Information 📚
N/A