feat: add classes ElementCreator, params and tests #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luchiweb
approved these changes
Aug 8, 2023
…Creator and modify the tests
OreskaG
reviewed
Aug 8, 2023
| @@ -0,0 +1,5 @@ | |||
| import { ElementParams } from './element-params-type'; | |||
There was a problem hiding this comment.
i would write these interfaces in one file, and name it something like utils-interfaces
OreskaG
reviewed
Aug 8, 2023
valr0lipsk
approved these changes
Aug 8, 2023
OreskaG
approved these changes
Aug 8, 2023
akrutsko
reviewed
Aug 8, 2023
akrutsko
reviewed
Aug 8, 2023
…ses in ElementCreator, use jest-dom methods for tests
akrutsko
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create class ElementCreator for adding HTTP Elements
Description of changes 🗣️
add types (interfaces) for creating HTMLElement, HTMLInputElement, HTMLButtonElement in folder "types"
add classes ElementCreator, ElementInputCreator, ElementButtonCreator in folder "utils/element-creator"
add tests for created classes
Related Tasks 🔗
N/A
Special Instructions for the Reviewers☝🏻
run "npm tun test" in terminal
Additional Information 📚
N/A