[18.0][IMP] split functions which need undefined dependencies#8
Open
remi-filament wants to merge 1 commit into
Open
[18.0][IMP] split functions which need undefined dependencies#8remi-filament wants to merge 1 commit into
remi-filament wants to merge 1 commit into
Conversation
|
Hi @alexis-via, |
remi-filament
force-pushed
the
18.0-imp-l10n_fr_einvoicing-split-functions
branch
from
b5f808f to
42826a9
Compare
remi-filament
added a commit
to lefilament/fr-einvoicing
that referenced
this pull request
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to split functions calling undefined dependencies such as base.document.import and Factur-x / UBL / CII document generation in separated functions so that these could be overriden in case one would like to use a different set of modules instead of the OCA ones (for instance Odoo account_edi_ubl_cii one)
@alexis-via could you please review this PR ?
I kept you original functions, so that they can easily be overriden for other contexts without impacting current behavior !
Although I think that using self.env["business.document.import"]._match_partner() in a function which should not raise error, where base.document.import model may not exist, is quite risky !
Closes #4