Skip to content
This repository has been archived by the owner on Oct 10, 2019. It is now read-only.

Commit

Permalink
Upgrade to Trusty on Travis
Browse files Browse the repository at this point in the history
  • Loading branch information
@Minoru
Minoru committed Aug 31, 2017
1 parent 9ae33b2 commit 97458b7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
language: cpp
dist: precise
dist: trusty
sudo: false

matrix:
fast_finish: true
Expand Down

4 comments on commit 97458b7

@polyzen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines should be superfluous: donnemartin/system-design-primer#93 (comment)

@Minoru
Copy link
Collaborator Author

@Minoru Minoru commented on 97458b7 Aug 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are there to check if anything fails on Trusty. Turns out pretty much everything fails :) I'm working on this.

@cclauss
Copy link

@cclauss cclauss commented on 97458b7 Sep 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend removing both the dist and the sudo lines as both of these are the default in Travis these days. We should not lock ourselves into trusty when Travis someday upgrades to the next distro.

@Minoru
Copy link
Collaborator Author

@Minoru Minoru commented on 97458b7 Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss, thank you for the recommendation, I applied it two days ago.

Please sign in to comment.