Feat: Improve performances for add/remove #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pool of entities ids (filled with deleted entities) allows to use a slice instead of a map to store entities & component register. The names are not manager by Volt anymore, the common method would be to add a MetadataComponent to the tracked entities (if necessary to fetch by names)
Clean documentation, removing entities names in the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming of entities is removed from the features. We can avoid using maps for storing entities in the world (replaced by a simple slice). It has a huge positive impact on the performances and the garbage collector.
The simplified componentsRegister removes another map, improving the performances too.
The documentation explains how to replace the naming feature in the client code. It also describes how to simply add callbacks to the lifecycle events.
Removing the naming feature creates a BREAKING CHANGE due to the removal of the name parameter & the removal of the search functions.