Improve writing performances #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can remove the entitiesNames map in the World structure. This relational map was used to keep track of the entities names per their EntityId.
The EntityId being a uint64, we can simply generate this using a hash value of the EntityName instead of a random: it simplifies the code, reduces the time spent to generate the random id (the hash seems faster than the rand).
Moreover, removing this relational map hugely reduces the memory usage (from 57996246 to 41214216 Bytes/operation in the benchmark BenchmarkCreateEntityVolt).
It was already the case but not strictly documented: the entity name MUST be unique, otherwise we would only rewrite on the same entity.