improved defineWindowMessaging functionality #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added optional parameter window for defineWindowMessaging
mehimanshupatil
commented
Sep 25, 2025
| * by default global window is used to send mesage | ||
| */ | ||
| export type WindowSendMessageArgs = [targetOrigin?: string]; | ||
| export type WindowSendMessageArgs = [targetOrigin?: string, targetWindow?: Window]; |
Author
There was a problem hiding this comment.
can have kept targetWindow first and then targetOrigin but don't this to be released as major version
Author
|
Hey @aaronklinker-st can you look into this as cant use for messaging from iframe to parent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added optional parameter window for defineWindowMessaging sendMessage function
fixes #90
so currently Window Messaging works by sending message on window but the reference of window object is based on which window you want to send message to.
like for sending message from injected code in iframe you need to refer
window.parentand notwindow