DnsExt: Resolve ManagerClass Type from IDnsProvider #7727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't find a specific test to run locally in order to verify if my change breaks anything, but that worked for me in another PR |
|
seems to be a flaky unrelated test, is it not? |
Yep, it's #7710 rearing its head again |
anpin
added a commit
to anpin/Akka.Management
that referenced
this pull request
Jul 14, 2025
6 tasks
anpin
added a commit
to anpin/Akka.Management
that referenced
this pull request
Jul 17, 2025
This was referenced Jul 25, 2025
This was referenced Aug 4, 2025
This was referenced Aug 15, 2025
This was referenced Aug 22, 2025
Aaronontheweb
added a commit
to akkadotnet/Akka.Management
that referenced
this pull request
Aug 29, 2025
* init Akka.Discovery.Dns only A/AAAA records are supported at this moment * init dns cluster example * SRV example cluster is starting * cleanup commented code and typos * Custom override for DnsExt is no longer required see akkadotnet/akka.net#7727 * fix IPv6 formating * fix logging of parsed IP records * separate A and AAAA examples * use dns.oci root domain instead of default dns.podman for runtime independent expirience * use docker-compose to run examples as it is more common * fix reference HOCON * cleanup hosting extensions * make internals availiable to tests * tests for DNS lookup and config parsing * Handle multiple nameservers * Cache for async-dns resolver * Refactor AsyncDnsClient: - Rename DnsClient to AsyncDnsClient.cs - Drop answer wrapper messages and use DnsProtocol.Message directly - Fix handling of legacy IO.Dns.Resolve requests - Add tests for various combinations of positive-ttl parameter which affect caching strategy * Add IDnsProviderWithSrvLookup and refactor tests * test TCP fallback client * Add missing options to hosting extension * remove leaked local dev settings * Upgrade to Akka.NET v1.5.46 * skip check of AAAA records on Windows with default resolver * update docs * fix compiler warnings and slight cache refactor * Add additional records to lookup result * add doc comments * reduce line noise * Fix/add documentation * make constructors for immutable messages private * Make TcpDropped message immutable and handle it * Remove unreferenced DropRequest message and handlers * Reply with error on TCP failure * Refactor query ID generation * applied copilot suggestions * add better comment * Fix DNS resolution in cluster bootstrap examples The dig commands in entrypoint.sh were not specifying the DNS server address, causing them to use the default Docker resolver (127.0.0.11) instead of the configured CoreDNS server. This prevented the demo containers from properly resolving service discovery records. Added @$DNS_SERVER parameter to all dig commands to ensure they query the correct DNS server specified by the DNS_NAMESERVER environment variable. --------- Co-authored-by: Aaron Stannard <aaron@petabridge.com> Co-authored-by: Gregorius Soedharmo <arkatufus@yahoo.com>
This was referenced Sep 4, 2025
This was referenced Sep 23, 2025
This was referenced Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7726
Changes
DnsExt resolves
ManagerClassType from IDnsProvider instead of hardcodedSimpleDnsManagerChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksInclude data from the relevant benchmark prior to this change here.
This PR's Benchmarks
Include data from after this change here.