[Streams] Allow GroupBy with infinite output substreams #7607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Apr 28, 2025
| @@ -419,9 +419,9 @@ public void OnPush() | |||
| } | |||
| else | |||
| { | |||
| if (_activeSubstreams.Count + _closedSubstreams.Count == _stage._maxSubstreams) | |||
| if (_stage._maxSubstreams > -1 && _activeSubstreams.Count + _closedSubstreams.Count == _stage._maxSubstreams) | |||
There was a problem hiding this comment.
Actual fix. Only check substream overflow condition if _maxSubstream is greater than or equals to 0.
| /// </para> | ||
| /// See <seealso cref="GroupBy{TIn, TOut, TMat, TKey}(Flow{TIn, TOut, TMat}, int, Func{TOut, TKey}, bool)"/> | ||
| /// </summary> | ||
| /// <typeparam name="TIn">TBD</typeparam> |
There was a problem hiding this comment.
@Arkatufus just a general note going forward, just don't have a comment instead of a TBD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7514
Changes
maxSubstreamsargument.FlowandSourcefluent API that does not require themaxSubstreamsargument.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):