Fix Akka.Util.Result edge case
#7433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Dec 23, 2024
Comment on lines
+146
to
+158
| if (task.IsCanceled && task.Exception is null) | ||
| { | ||
| try | ||
| { | ||
| _ = task.GetAwaiter().GetResult(); | ||
| } | ||
| catch(Exception e) | ||
| { | ||
| return new Result<T>(e); | ||
| } | ||
|
|
||
| throw new InvalidOperationException("Should never reach this line!"); | ||
| } |
There was a problem hiding this comment.
Fix, detect edge case where a Task is cancelled and its Exception property is null.
Arkatufus
commented
Dec 23, 2024
Comment on lines
+140
to
+141
| if(!task.IsCompleted) | ||
| throw new ArgumentException("Task is not completed. Result.FromTask only accepts completed tasks.", nameof(task)); |
There was a problem hiding this comment.
New behavior, .FromTask() did not check if the Task argument is completed or not, it should only accept completed tasks
This was referenced Oct 7, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7432
Changes
Akka.Util.Result<T>.FromTask()checks for edge casesAkka.Util.Result<T>.FromTask()behavior, it will now throw if theTaskargument is not completed.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):