Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streams] Fix ShellRegistered message deadletter log #7376

Merged
merged 1 commit into from
Nov 1, 2024
Merged

[Streams] Fix ShellRegistered message deadletter log #7376

merged 1 commit into from
Nov 1, 2024

Conversation

Arkatufus
Copy link
Contributor

Fixes #7369

ShellRegistered is the same as the Resume internal API message in JVM, it is used to prevent/short circuit recursion inside a stream. Harmless when dead-lettered.

Changes

  • Make ShellRegistered inherits IDeadLetterSuppression marker interface.

Aaronontheweb
Aaronontheweb approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) November 1, 2024 17:03
@Aaronontheweb Aaronontheweb merged commit 699aff2 into akkadotnet:dev Nov 1, 2024
12 checks passed
@Arkatufus Arkatufus mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-streams logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Akka.Streams ShellRegistered message to Self was dead lettered
2 participants
@Arkatufus @Aaronontheweb