-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix EventSourced Stash filtering out identical envelopes #7375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EventSourced Stash filtering out identical envelopes #7375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll merge this in and then re-run #7374
Ooops I did mean to leave one comment on this... The behavior is semantically correct, should note it may or may not lead to 'vexing' behaviors for consumers that are inadvertently dependent on the behavior (e.x. repeated externally fired messages and they don't have proper guarding. tl;dr- Good mention in release notes would be nice, I know I've had to write code to get around this in the past. <3 |
We'll try to address this on the front-end with akkadotnet/akka.analyzers#104 - but yes, we'll also add an upgrade advisory for this issue in v1.5.31 |
Fixes #7373
Changes
Removed the
Distinct()
filter