Fix Hyperion serializer config bug #7364
Conversation
| # If true, hyperion serializer will preserve references between objects. | ||
| # This is necessary to support things such as cyclic dependencies between objects. | ||
| preserve-object-references = true | ||
| serializers { |
There was a problem hiding this comment.
Nothing is changed on the default config file, all changes were white space changes from tab to spaces to make sure that text formatting is consistent
| @@ -170,7 +170,8 @@ public sealed class HyperionSerializerSettings | |||
| /// <summary> | |||
| /// Default settings used by <see cref="HyperionSerializer"/> when no config has been specified. | |||
| /// </summary> | |||
| public static readonly HyperionSerializerSettings Default = Create(HyperionSerializer.DefaultConfiguration()); | |||
| public static readonly HyperionSerializerSettings Default = Create(HyperionSerializer.DefaultConfiguration() | |||
| .GetConfig("akka.actor.serialization-settings.hyperion")); | |||
There was a problem hiding this comment.
This is the actual config HyperionSerializerSettings was expecting, not the root config.
doesn't this mean that the defaults behaviors, if different than what the HOCON specifies, are now enforced? |
|
Luckily, all of the default values are exactly the same to what we've assigned if the config were empty. So this PR have no behavior impact, unless we change the default values. |
Yes and no, yes if the default were different, luckily it is not. |
|
That's good to know - thanks @Arkatufus |
The
HyperionSerializer(ExtendedActorSystem)ctor method uses the wrong HOCON config.HyperionSerializerConfig.Create()expects the config from the "akka.actor.serialization-settings.hyperion" path, but theHyperionSerializerctor passes the HOCON root config to it.Behavior change after this PR:
No known behavioral change.
Changes