Improve Streams SelectAsync. Log errors and improve test #6884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Aug 16, 2023
| if (_decider(e) == Directive.Stop) | ||
| FailStage(e); | ||
| var strategy = _decider(e); | ||
| Log.Error(e, "An exception occured inside SelectAsync while processing message [{0}]. Supervision strategy: {1}", message, strategy); |
There was a problem hiding this comment.
LGTM - should resolve #6878
|
|
||
| var exception = element.Exception; | ||
| var strategy = _decider(exception); | ||
| Log.Error(exception, "An exception occured inside SelectAsync while executing Task. Supervision strategy: {0}", strategy); |
| } | ||
|
|
||
| [Fact] | ||
| public async Task A_Flow_with_SelectAsync_must_signal_task_failure() |
There was a problem hiding this comment.
LGTM - this is exactly the behavior we expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6877
close #6878
Changes