Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enabled Akka.FSharp.Tests on .NET Core 3.1, .NET 5.0 #5195

Merged
merged 1 commit into from
Aug 12, 2021
Merged

re-enabled Akka.FSharp.Tests on .NET Core 3.1, .NET 5.0 #5195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/core/Akka.FSharp.Tests/Akka.FSharp.Tests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<PropertyGroup>
<AssemblyTitle>Akka.FSharp.Tests</AssemblyTitle>
<TargetFrameworks>$(NetFrameworkTestVersion);netstandard2.0</TargetFrameworks>
<TargetFrameworks>$(NetFrameworkTestVersion);$(NetTestVersion);$(NetCoreTestVersion)</TargetFrameworks>
<IsPackable>false</IsPackable>
<NoWarn></NoWarn>
</PropertyGroup>
Expand Down Expand Up @@ -32,6 +32,10 @@
<PackageReference Include="xunit.runner.visualstudio" Version="$(XunitVersion)" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == '$(NetCoreTestVersion)' OR '$(TargetFramework)' == '$(NetTestVersion)'">
<DefineConstants>$(DefineConstants);CORECLR</DefineConstants>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
<DefineConstants>$(DefineConstants);RELEASE</DefineConstants>
</PropertyGroup>
Expand Down
3 changes: 2 additions & 1 deletion src/core/Akka.FSharp.Tests/ApiTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@ open Akka.Actor
open System
open Xunit


#if !CORECLR // not supported on .NET Core / .NET 5
[<Fact>]
let ``configuration loader should load data from app.config`` () =
let config = Configuration.load()
config.HasPath "akka.test.value"
|> equals true
config.GetInt "akka.test.value"
|> equals 10
#endif

[<Fact>]
let ``can serialize expression decider`` () =
Expand Down