Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported DivertTo combinator #5137

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Ported DivertTo combinator #5137

merged 1 commit into from
Jul 14, 2021

Conversation

ismaelhamed
Copy link
Member

Port #24310

@ismaelhamed ismaelhamed force-pushed the divertTo-combinator branch 2 times, most recently from e310253 to b4db17a Compare July 13, 2021 05:29
Aaronontheweb
Aaronontheweb requested changes Jul 13, 2021
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add some docs for this on the "built in stages" page for Akka.Streams docs

src/core/Akka.Streams/Dsl/FlowOperations.cs
@@ -1801,6 +1801,49 @@ public static class FlowOperations
return (Flow<TIn, TOut, TMat>)InternalFlowOperations.AlsoTo(flow, that);
}

/// <summary>
/// Attaches the given <seealso cref="Sink{TIn,TMat}"/> to this <see cref="Flow{TIn,TOut,TMat}"/>, meaning that elements
/// will be sent to the <seealso cref="Sink{TIn,TMat}"/> instead of being passed through if the predicate `when` returns `true`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ismaelhamed
Copy link
Member Author

Updated documentation with a brief description

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) July 14, 2021 14:45
@Aaronontheweb Aaronontheweb merged commit c835e85 into akkadotnet:dev Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismaelhamed @Aaronontheweb