Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include attempted bind address in DotNetty binding failure messages #5132

Merged
merged 4 commits into from
Jul 6, 2021
Merged

include attempted bind address in DotNetty binding failure messages #5132

merged 4 commits into from
Jul 6, 2021

Conversation

Aaronontheweb
Copy link
Member

close #5130

Calling Endpoint.ToString() should be good enough:

EndPoint ipEndpoint = new IPEndPoint(IPAddress.Parse("127.0.0.1"), 2002);
EndPoint dnsEndpoint = new DnsEndPoint("localhost", 2003);
Console.WriteLine(ipEndpoint.ToString());
Console.WriteLine(dnsEndpoint.ToString());

Output:

127.0.0.1:2002
Unspecified/localhost:2003

@Aaronontheweb Aaronontheweb mentioned this pull request Jul 6, 2021
Closed
object
object approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@object object left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) July 6, 2021 14:45
@Aaronontheweb Aaronontheweb merged commit 0a21bc2 into akkadotnet:dev Jul 6, 2021
@Aaronontheweb Aaronontheweb deleted the fix/5130-remote-bind-error-address branch July 6, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@object object object approved these changes

Assignees
No one assigned
Labels
akka-remote dotnetty
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can DotNetty socket exception include information about the address?
2 participants
@Aaronontheweb @object