Akka.Coordination: minor cleanup #5074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
added
the
akka-coordination
Aaronontheweb
commented
Jun 4, 2021
| @@ -385,7 +386,7 @@ private void OnAcquireLease() | |||
|
|
|||
| public Receive WaitingForLease(IDecision decision) | |||
| { | |||
| bool Receive(object message) | |||
| bool ReceiveLease(object message) | |||
There was a problem hiding this comment.
Receive was hiding the ActorBase.Receive method - renamed it.
| @@ -83,7 +83,7 @@ public static LeaseProvider Get(ActorSystem system) | |||
| } | |||
|
|
|||
| private readonly ExtendedActorSystem _system; | |||
| private readonly ConcurrentDictionary<LeaseKey, Lease> leases = new ConcurrentDictionary<LeaseKey, Lease>(); | |||
| private readonly ConcurrentDictionary<LeaseKey, Lease> _leases = new ConcurrentDictionary<LeaseKey, Lease>(); | |||
| @@ -151,7 +151,7 @@ public Lease GetLease(string leaseName, string configPath, string ownerName) | |||
| Log.Error( | |||
| ex, | |||
| "Invalid lease configuration for leaseName [{0}], configPath [{1}] lease-class [{2}]. " + | |||
| "The class must implement scaladsl.Lease or javadsl.Lease and have constructor with LeaseSettings parameter and " + | |||
| "The class must implement Akka.Coordination.Lease and have constructor with LeaseSettings parameter and " + | |||
There was a problem hiding this comment.
Changed this comment to match the .NET FQN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up some internal issues with Akka.Coordination and how it's used inside Akka.Cluster.