Fix AkkaProtocolStressTest spec #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
May 17, 2021
| @@ -190,7 +192,12 @@ public void AkkaProtocolTransport_must_guarantee_at_most_once_delivery_and_messa | |||
| new FailureInjectorTransportAdapter.Drop(0.1, 0.1))); | |||
| AwaitCondition(() => mc.IsCompleted && mc.Result, TimeSpan.FromSeconds(3)); | |||
|
|
|||
| var here = Here; | |||
| IActorRef here = null; | |||
| AwaitCondition(() => | |||
There was a problem hiding this comment.
Here property uses ActorSelection that can return a null Subject that causes NRE down the line (caused by EmptyLocalActorRef). Using AwaitCondition here to force the spec to wait until Here returns a valid IActorRef
There was a problem hiding this comment.
LGTM - how many times did you run this one successively without failures?
There was a problem hiding this comment.
1000 times minimum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.