Upgraded to Akka.NET v1.5.0 (#291)

* upgraded to Akka.NET v1.5 * added v1.5 release notes
akkadotnet · Mar 2, 2023 · 14c1171 · 14c1171
1 parent dbceba1
commit 14c1171
Show file tree

Hide file tree

Showing 21 changed files with 152 additions and 93 deletions.
diff --git a/Akka.Persistence.SqlServer.sln b/Akka.Persistence.SqlServer.sln
@@ -8,6 +8,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build", "build", "{D8BAD8E8
 		build.cmd = build.cmd
 		build.fsx = build.fsx
 		build.sh = build.sh
+		src\Directory.Build.props = src\Directory.Build.props
+		src\Directory.Packages.props = src\Directory.Packages.props
 	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{85A25CFE-0B51-45FC-9C5E-271F9557F8D3}"

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,3 +1,6 @@
-#### 1.5.0-beta3 February 27 2023 ####
+#### 1.5.0 March 02 2023 ####
+
+* [Update Akka.NET to v1.5.0](https://github.com/akkadotnet/akka.net/releases/tag/1.5.0)
+
 
 * [Update Akka.NET to v1.5.0-beta3](https://github.com/akkadotnet/akka.net/releases/tag/1.5.0-beta3)
diff --git a/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerAllEventsSpec.cs b/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerAllEventsSpec.cs
@@ -5,7 +5,6 @@
 // -----------------------------------------------------------------------
 
 using System;
-using System.Threading.Tasks;
 using Akka.Configuration;
 using Akka.Persistence.Query;
 using Akka.Persistence.Query.Sql;
@@ -16,7 +15,7 @@
 namespace Akka.Persistence.SqlServer.Tests.Batching
 {
     [Collection("SqlServerSpec")]
-    public class BatchingSqlServerAllEventsSpec : AllEventsSpec
+    public class BatchingSqlServerAllEventsSpec : AllEventsSpec, IDisposable
     {
         public BatchingSqlServerAllEventsSpec(ITestOutputHelper output, SqlServerFixture fixture) : base(
             InitConfig(fixture),
@@ -43,11 +42,15 @@ class = ""Akka.Persistence.SqlServer.Journal.BatchingSqlServerJournal, Akka.Pers
                 .WithFallback(SqlReadJournal.DefaultConfiguration());
         }
 
-        public override Task DisposeAsync()
+        protected void Dispose(bool disposing)
         {
-            GC.SuppressFinalize(this);
             DbUtils.Clean();
-            return base.DisposeAsync();
+        }
+
+        public void Dispose()
+        {
+            GC.SuppressFinalize(this);
+            Dispose(true);
         }
     }
 }
diff --git a/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerCurrentAllEventsSpec.cs b/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerCurrentAllEventsSpec.cs
@@ -5,7 +5,6 @@
 // -----------------------------------------------------------------------
 
 using System;
-using System.Threading.Tasks;
 using Akka.Configuration;
 using Akka.Persistence.Query;
 using Akka.Persistence.Query.Sql;
@@ -16,7 +15,7 @@
 namespace Akka.Persistence.SqlServer.Tests.Batching
 {
     [Collection("SqlServerSpec")]
-    public class BatchingSqlServerCurrentAllEventsSpec : CurrentAllEventsSpec
+    public class BatchingSqlServerCurrentAllEventsSpec : CurrentAllEventsSpec, IDisposable
     {
         public BatchingSqlServerCurrentAllEventsSpec(ITestOutputHelper output, SqlServerFixture fixture) : base(
             InitConfig(fixture),
@@ -43,11 +42,15 @@ class = ""Akka.Persistence.SqlServer.Journal.BatchingSqlServerJournal, Akka.Pers
                 .WithFallback(SqlReadJournal.DefaultConfiguration());
         }
 
-        public override Task DisposeAsync()
+        protected void Dispose(bool disposing)
         {
-            GC.SuppressFinalize(this);
             DbUtils.Clean();
-            return base.DisposeAsync();
+        }
+
+        public void Dispose()
+        {
+            GC.SuppressFinalize(this);
+            Dispose(true);
         }
     }
 }
diff --git a/...Persistence.SqlServer.Tests/Batching/BatchingSqlServerCurrentEventsByPersistenceIdSpec.cs b/...Persistence.SqlServer.Tests/Batching/BatchingSqlServerCurrentEventsByPersistenceIdSpec.cs
@@ -5,7 +5,6 @@
 // -----------------------------------------------------------------------
 
 using System;
-using System.Threading.Tasks;
 using Akka.Configuration;
 using Akka.Persistence.Query;
 using Akka.Persistence.Query.Sql;
@@ -16,7 +15,7 @@
 namespace Akka.Persistence.SqlServer.Tests.Batching
 {
     [Collection("SqlServerSpec")]
-    public class BatchingSqlServerCurrentEventsByPersistenceIdSpec : CurrentEventsByPersistenceIdSpec
+    public class BatchingSqlServerCurrentEventsByPersistenceIdSpec : CurrentEventsByPersistenceIdSpec, IDisposable
     {
         public BatchingSqlServerCurrentEventsByPersistenceIdSpec(ITestOutputHelper output, SqlServerFixture fixture)
             : base(InitConfig(fixture), nameof(BatchingSqlServerCurrentEventsByPersistenceIdSpec), output)
@@ -45,11 +44,15 @@ class = ""Akka.Persistence.SqlServer.Journal.BatchingSqlServerJournal, Akka.Pers
             return conf.WithFallback(SqlReadJournal.DefaultConfiguration());
         }
 
-        public override Task DisposeAsync()
+        protected void Dispose(bool disposing)
         {
-            GC.SuppressFinalize(this);
             DbUtils.Clean();
-            return base.DisposeAsync();
+        }
+
+        public void Dispose()
+        {
+            GC.SuppressFinalize(this);
+            Dispose(true);
         }
     }
 }
diff --git a/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerCurrentEventsByTagSpec.cs b/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerCurrentEventsByTagSpec.cs
@@ -5,7 +5,6 @@
 // -----------------------------------------------------------------------
 
 using System;
-using System.Threading.Tasks;
 using Akka.Configuration;
 using Akka.Persistence.Query;
 using Akka.Persistence.Query.Sql;
@@ -16,7 +15,7 @@
 namespace Akka.Persistence.SqlServer.Tests.Batching
 {
     [Collection("SqlServerSpec")]
-    public class BatchingSqlServerCurrentEventsByTagSpec : EventsByTagSpec
+    public class BatchingSqlServerCurrentEventsByTagSpec : EventsByTagSpec, IDisposable
     {
         public BatchingSqlServerCurrentEventsByTagSpec(ITestOutputHelper output, SqlServerFixture fixture)
             : base(InitConfig(fixture), nameof(BatchingSqlServerCurrentEventsByTagSpec), output)
@@ -51,11 +50,15 @@ class = ""Akka.Persistence.SqlServer.Journal.SqlServerJournal, Akka.Persistence.
             return conf.WithFallback(SqlReadJournal.DefaultConfiguration());
         }
 
-        public override Task DisposeAsync()
+        protected void Dispose(bool disposing)
         {
-            GC.SuppressFinalize(this);
             DbUtils.Clean();
-            return base.DisposeAsync();
+        }
+
+        public void Dispose()
+        {
+            GC.SuppressFinalize(this);
+            Dispose(true);
         }
     }
 }
diff --git a/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerCurrentPersistenceIdsSpec.cs b/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerCurrentPersistenceIdsSpec.cs
@@ -5,7 +5,6 @@
 // -----------------------------------------------------------------------
 
 using System;
-using System.Threading.Tasks;
 using Akka.Configuration;
 using Akka.Persistence.Query;
 using Akka.Persistence.Query.Sql;
@@ -16,7 +15,7 @@
 namespace Akka.Persistence.SqlServer.Tests.Batching
 {
     [Collection("SqlServerSpec")]
-    public class BatchingSqlServerCurrentPersistenceIdsSpec : CurrentPersistenceIdsSpec
+    public class BatchingSqlServerCurrentPersistenceIdsSpec : CurrentPersistenceIdsSpec, IDisposable
     {
         public BatchingSqlServerCurrentPersistenceIdsSpec(ITestOutputHelper output, SqlServerFixture fixture)
             : base(InitConfig(fixture), nameof(BatchingSqlServerCurrentPersistenceIdsSpec), output)
@@ -45,11 +44,15 @@ class = ""Akka.Persistence.SqlServer.Journal.BatchingSqlServerJournal, Akka.Pers
             return conf.WithFallback(SqlReadJournal.DefaultConfiguration());
         }
 
-        public override Task DisposeAsync()
+        protected void Dispose(bool disposing)
         {
-            GC.SuppressFinalize(this);
             DbUtils.Clean();
-            return base.DisposeAsync();
+        }
+
+        public void Dispose()
+        {
+            GC.SuppressFinalize(this);
+            Dispose(true);
         }
     }
 }
diff --git a/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerEventsByPersistenceIdSpec.cs b/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerEventsByPersistenceIdSpec.cs
@@ -5,7 +5,6 @@
 // -----------------------------------------------------------------------
 
 using System;
-using System.Threading.Tasks;
 using Akka.Configuration;
 using Akka.Persistence.Query;
 using Akka.Persistence.Query.Sql;
@@ -16,7 +15,7 @@
 namespace Akka.Persistence.SqlServer.Tests.Batching
 {
     [Collection("SqlServerSpec")]
-    public class BatchingSqlServerEventsByPersistenceIdSpec : EventsByPersistenceIdSpec
+    public class BatchingSqlServerEventsByPersistenceIdSpec : EventsByPersistenceIdSpec, IDisposable
     {
         public BatchingSqlServerEventsByPersistenceIdSpec(ITestOutputHelper output, SqlServerFixture fixture)
             : base(InitConfig(fixture), nameof(BatchingSqlServerEventsByPersistenceIdSpec), output)
@@ -45,11 +44,15 @@ class = ""Akka.Persistence.SqlServer.Journal.BatchingSqlServerJournal, Akka.Pers
             return conf.WithFallback(SqlReadJournal.DefaultConfiguration());
         }
 
-        public override Task DisposeAsync()
+        protected void Dispose(bool disposing)
         {
-            GC.SuppressFinalize(this);
             DbUtils.Clean();
-            return base.DisposeAsync();
+        }
+
+        public void Dispose()
+        {
+            GC.SuppressFinalize(this);
+            Dispose(true);
         }
     }
 }
diff --git a/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerEventsByTagSpec.cs b/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerEventsByTagSpec.cs
@@ -5,7 +5,6 @@
 // -----------------------------------------------------------------------
 
 using System;
-using System.Threading.Tasks;
 using Akka.Configuration;
 using Akka.Persistence.Query;
 using Akka.Persistence.Query.Sql;
@@ -16,7 +15,7 @@
 namespace Akka.Persistence.SqlServer.Tests.Batching
 {
     [Collection("SqlServerSpec")]
-    public class BatchingSqlServerEventsByTagSpec : EventsByTagSpec
+    public class BatchingSqlServerEventsByTagSpec : EventsByTagSpec, IDisposable
     {
         public BatchingSqlServerEventsByTagSpec(ITestOutputHelper output, SqlServerFixture fixture)
             : base(InitConfig(fixture), nameof(BatchingSqlServerEventsByTagSpec), output)
@@ -51,11 +50,15 @@ class = ""Akka.Persistence.SqlServer.Journal.SqlServerJournal, Akka.Persistence.
             return conf.WithFallback(SqlReadJournal.DefaultConfiguration());
         }
 
-        public override Task DisposeAsync()
+        protected void Dispose(bool disposing)
         {
-            GC.SuppressFinalize(this);
             DbUtils.Clean();
-            return base.DisposeAsync();
+        }
+
+        public void Dispose()
+        {
+            GC.SuppressFinalize(this);
+            Dispose(true);
         }
     }
 }
diff --git a/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerJournalPerfSpec.cs b/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerJournalPerfSpec.cs
@@ -5,7 +5,6 @@
 // -----------------------------------------------------------------------
 
 using System;
-using System.Threading.Tasks;
 using Akka.Configuration;
 using Akka.Persistence.TestKit.Performance;
 using Xunit;
@@ -14,7 +13,7 @@
 namespace Akka.Persistence.SqlServer.Tests
 {
     [Collection("SqlServerSpec")]
-    public class BatchingSqlServerJournalPerfSpec : JournalPerfSpec
+    public class BatchingSqlServerJournalPerfSpec : JournalPerfSpec, IDisposable
     {
         public BatchingSqlServerJournalPerfSpec(ITestOutputHelper output, SqlServerFixture fixture)
             : base(InitConfig(fixture), "BatchingSqlServerJournalPerfSpec", output)
@@ -48,11 +47,15 @@ class = ""Akka.Persistence.SqlServer.Journal.BatchingSqlServerJournal, Akka.Pers
             return ConfigurationFactory.ParseString(specString);
         }
 
-        public override Task DisposeAsync()
+        protected void Dispose(bool disposing)
         {
-            GC.SuppressFinalize(this);
             DbUtils.Clean();
-            return base.DisposeAsync();
+        }
+
+        public void Dispose()
+        {
+            GC.SuppressFinalize(this);
+            Dispose(true);
         }
     }
 }
diff --git a/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerPersistenceIdsSpec.cs b/src/Akka.Persistence.SqlServer.Tests/Batching/BatchingSqlServerPersistenceIdsSpec.cs
@@ -5,7 +5,6 @@
 // -----------------------------------------------------------------------
 
 using System;
-using System.Threading.Tasks;
 using Akka.Configuration;
 using Akka.Persistence.Query;
 using Akka.Persistence.Query.Sql;
@@ -16,7 +15,7 @@
 namespace Akka.Persistence.SqlServer.Tests.Batching
 {
     [Collection("SqlServerSpec")]
-    public class BatchingSqlServerPersistenceIdsSpec : PersistenceIdsSpec
+    public class BatchingSqlServerPersistenceIdsSpec : PersistenceIdsSpec, IDisposable
     {
         public BatchingSqlServerPersistenceIdsSpec(ITestOutputHelper output, SqlServerFixture fixture)
             : base(InitConfig(fixture), nameof(BatchingSqlServerPersistenceIdsSpec), output)
@@ -45,11 +44,15 @@ class = ""Akka.Persistence.SqlServer.Journal.BatchingSqlServerJournal, Akka.Pers
             return conf.WithFallback(SqlReadJournal.DefaultConfiguration());
         }
 
-        public override Task DisposeAsync()
+        protected void Dispose(bool disposing)
         {
-            GC.SuppressFinalize(this);
             DbUtils.Clean();
-            return base.DisposeAsync();
+        }
+
+        public void Dispose()
+        {
+            GC.SuppressFinalize(this);
+            Dispose(true);
         }
     }
 }
diff --git a/src/Akka.Persistence.SqlServer.Tests/Query/SqlServerAllEventsSpec.cs b/src/Akka.Persistence.SqlServer.Tests/Query/SqlServerAllEventsSpec.cs
@@ -5,7 +5,6 @@
 // -----------------------------------------------------------------------
 
 using System;
-using System.Threading.Tasks;
 using Akka.Configuration;
 using Akka.Persistence.Query;
 using Akka.Persistence.Query.Sql;
@@ -16,7 +15,7 @@
 namespace Akka.Persistence.SqlServer.Tests.Query
 {
     [Collection("SqlServerSpec")]
-    public class SqlServerAllEventsSpec : AllEventsSpec
+    public class SqlServerAllEventsSpec : AllEventsSpec, IDisposable
     {
         public SqlServerAllEventsSpec(ITestOutputHelper output, SqlServerFixture fixture) : base(InitConfig(fixture),
             nameof(SqlServerAllEventsSpec), output)
@@ -49,11 +48,15 @@ class = ""Akka.Persistence.SqlServer.Journal.SqlServerJournal, Akka.Persistence.
                 .WithFallback(SqlReadJournal.DefaultConfiguration());
         }
 
-        public override Task DisposeAsync()
+        protected void Dispose(bool disposing)
         {
-            GC.SuppressFinalize(this);
             DbUtils.Clean();
-            return base.DisposeAsync();
+        }
+
+        public void Dispose()
+        {
+            GC.SuppressFinalize(this);
+            Dispose(true);
         }
     }
 }