Skip to content

Conversation

@Aaronontheweb
Copy link
Member

Summary

  • Added optional tags parameter to WithConnectivityCheck methods for both journal and snapshot store
  • Maintains backward compatibility with default tags when parameter is not provided
  • Consistent with recent changes in MongoDB and Redis persistence plugins

Changes

  • Updated SqlConnectivityCheckExtensions.WithConnectivityCheck methods to accept optional string[]? tags parameter
  • Default tags remain ["akka", "persistence", "sql", "journal", "connectivity"] and ["akka", "persistence", "sql", "snapshot-store", "connectivity"]

Test plan

  • All existing tests pass (22 connectivity check tests)
  • Backward compatibility maintained - existing code without tags parameter continues to work

- Updated WithConnectivityCheck methods to accept optional tags parameter
- Maintains backward compatibility with default tags
- Consistent with recent changes in MongoDB and Redis persistence plugins
Copy link
Member Author

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant