Skip to content

Conversation

@Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Jun 23, 2025

Memory leak caused by CancellationTokenSource has been observed in the snapshot store DAO.

Changes

Add missing using keyword in ByteArraySnapshotDao to make sure that all CancellationTokenSource are disposed properly.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Latest dev Benchmarks

Benchmark was done by continuously creating new ReceivePersistentActor at the rate of 50 actors per second for 5 minutes. Memory snapshot were taken using Jetbrains DotMemory using API before and after the actor creation spam and were compared to check for memory leak.

image

This PR's Benchmarks

image

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants