Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WithExtensions so it can be used universally #92

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Improve WithExtensions so it can be used universally #92

merged 1 commit into from
Aug 11, 2022

Conversation

Arkatufus
Copy link
Contributor

Changes

Improve WithExtensions so that it can:

  • Be called multiple times without overriding each other
  • Be used together along side manually declared extensions in HOCON

Aaronontheweb
Aaronontheweb approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit d27f0e6 into akkadotnet:dev Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb