Support custom health check registrations on Journal and Snapshot Builders #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
added
akka-persistence
dx
Aaronontheweb
commented
Oct 25, 2025
There was a problem hiding this comment.
New methods - they don't do anything all that functionally different than the main health check registration methods on the AkkaConfigurationBuilder. This is a pure DX choice to support Akka.Persistence plugin authors.
There was a problem hiding this comment.
Moved the builders to their own files because I was tired of having to go looking for them
| { | ||
| internal readonly string SnapshotStoreId; | ||
| internal readonly AkkaConfigurationBuilder Builder; | ||
| internal readonly HashSet<AkkaHealthCheckRegistration> HealthCheckRegistrations = []; |
There was a problem hiding this comment.
Now we take a hashset of health check registrations, rather than a singular registration.
3 tasks
This was referenced Oct 27, 2025
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
API addition that is needed to properly support #678
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):