-
Couldn't load subscription status.
- Fork 22
Add customizable tags parameter to health check methods (#679) #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Aaronontheweb
merged 4 commits into
akkadotnet:dev
from
Aaronontheweb:feature/679-customizable-health-check-tags
Oct 25, 2025
Merged
Add customizable tags parameter to health check methods (#679) #681
Aaronontheweb
merged 4 commits into
akkadotnet:dev
from
Aaronontheweb:feature/679-customizable-health-check-tags
Oct 25, 2025
+20
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements issue akkadotnet#679: Allow users to customize tags for health checks via optional parameter. - Added optional `tags` parameter to AkkaPersistenceJournalBuilder.WithHealthCheck() - Added optional `tags` parameter to AkkaPersistenceSnapshotBuilder.WithHealthCheck() - When tags parameter is null, defaults to ["akka", "persistence", "journal"] or ["akka", "persistence", "snapshot-store"] - Consolidates previous overloads into single method with all optional parameters to avoid ambiguity - All 18 health check tests pass
28b73a2 to
533a3c5
Compare
…tern Updated AkkaPersistenceJournalBuilder and AkkaPersistenceSnapshotBuilder to use optional parameters instead of method overloads, following the pattern established in PR akkadotnet#682 for consistency across the codebase. Changes: - Removed separate overloads for WithHealthCheck() methods - Added optional 'tags' parameter to existing methods - Updated API approval tests to reflect new signatures - All tests pass successfully
3 tasks
This was referenced Oct 27, 2025
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #679: Add customizable tags parameter to health check builder methods to allow users to override default health check tags.
Changes
Adds a new overload of
WithHealthCheck()methods following extend-only design principles:WithHealthCheck(HealthStatus = Degraded, string? name = null)- maintains backward compatibilityWithHealthCheck(HealthStatus unHealthyStatus, string? name, IEnumerable<string>? tags)- allows custom tagsWhen tags parameter is null, defaults are applied:
["akka", "persistence", "journal"]["akka", "persistence", "snapshot-store"]Overloads have non-overlapping signatures to prevent method ambiguity:
Example Usage
Design Rationale
Testing