Add SSL TLS configuration settings changes from Akka v1.5.52 and v1.5.53 #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… v1.5.52 and v1.5.53 - Added RequireMutualAuthentication property to SslOptions (default: true as per v1.5.52) - Enables mutual TLS (mTLS) authentication where both client and server must present valid certificates - Provides defense-in-depth security for peer-to-peer Akka.Remote connections - Added ValidateCertificateHostname property to SslOptions (default: false as per v1.5.53) - Controls whether certificate hostname validation is performed during TLS handshake - Can be disabled for mutual TLS with per-node certificates, IP-based connections, or dynamic addresses - Updated Build method to include new settings in HOCON configuration - Added comprehensive unit tests for the new SSL/TLS settings - Added TODO comment for future DotNettySslSetup constructor usage when Akka.NET is upgraded to v1.5.53+ Note: Currently these settings are only applied via HOCON configuration. Direct DotNettySslSetup constructor support will be enabled when Akka.NET dependency is upgraded to v1.5.53 or later.
- Upgraded Akka.NET dependency from 1.5.52 to 1.5.53 - Updated version prefix to 1.5.53 - Removed "future implementation" comment and enabled the 4-parameter DotNettySslSetup constructor - Now directly passing RequireMutualAuthentication and ValidateCertificateHostname to DotNettySslSetup - Updated release notes to reflect the new SSL/TLS configuration features - All tests pass with the new version The new SSL/TLS settings are now fully integrated with both HOCON configuration and the DotNettySslSetup class.
Aaronontheweb
requested changes
Oct 14, 2025
| var sb = new StringBuilder(); | ||
|
|
||
| if (SuppressValidation is not null) |
There was a problem hiding this comment.
Are we supposed to use DotNettySslSetup anywhere in this class?
There was a problem hiding this comment.
we do, in line 118
This was referenced Oct 14, 2025
This was referenced Oct 22, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.