[Breaking Change] remove default HoconAddMode from HOCON builders
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this is a breaking change for all Akka.Hosting extension plugins
|
As of the latest discussion with @Aaronontheweb, we will remove the default value instead. |
Aaronontheweb
approved these changes
Nov 21, 2022
Aaronontheweb
changed the title
HoconAddMode from HOCON builders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
Changes
WARNING
This is a breaking change for all Akka.Hosting extension plugins
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):