Convert Windows paths to WSL paths when running under WSL #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akiyosi
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Please address the following two points:
- Run
go fmtto format the code according to Go's style guidelines. - When checking for a colon after the drive letter in
convertWindowsToUnixPath(), consider adding an early return if the path is less than two characters long to avoid potential issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a commit that adds functionality to convert Windows paths to Unix paths when running under Windows Subsystem for Linux (WSL). This is achieved by replacing backslashes with forward slashes and converting the drive letter to the corresponding
/mnt/<drive-letter>format. This enhancement ensures that file paths are correctly handled when running the software under WSL.fixes #548