pum_getpos() seems to return wrong value for ext_popupmenu

[acomagu]

When I see popup like this:

pum_getpos() returns such value:

The values of width, height and size seems to be far from those of native pum.

I understand they won't be exact same value, but I guess width and height should be more smaller.

Why I need this to be fixed

I use nvim-cmp as completion engine. When I use it with GoNeovim ExtPopupMenu, the floating window of documentation next to popup menu appears very narrow.

This problem may be caused because the width value of pum_getpos() is wrong.

Thank you!

[akiyosi]

@acomagu
Hi :D
Thanks for this issue report.
I was aware of the problem with the narrowing of the attached float window of the pop-up menu displayed by the completion plugin, but left it unattended because the cause was unknown :P

When ext_popupmenu is enabled, the ui uses nvim_ui_pum_set_bounds({width}, {height}, {row}, {col}) to inform the Neovim side of the position and size information of the external popup menu.
The cause of the problem was that the width and height in these arguments were passed as numerical values in pixels.

This problem has been fixed in 7024c9f.

[acomagu]

@akiyosi I can see it's fixed! Thank you for your incredibly quick work!

[akiyosi]

@acomagu
Also, I fixed a problem in 10fe882 with external popupmenu where the menu parts would partially cover the icon display, as seen in your screen capture.

[acomagu]

@akiyosi Wow, you helped me a lot!! Thank you!