fix: linter warnings

akiver · Jun 6, 2024 · bdf3131 · bdf3131
1 parent be8a2b7
commit bdf3131
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/linter/lingui-js-usage.ts b/linter/lingui-js-usage.ts
@@ -1,7 +1,7 @@
 import { ESLintUtils, ASTUtils, AST_NODE_TYPES } from '@typescript-eslint/utils';
 
 type Options = [];
-type MessagesIds = 'useLinguiMessage' | 'transComponentMessage' | 'useI18nMessage';
+type MessagesIds = 'useLinguiMessage' | 'transComponentMessage';
 
 /**
  * - Ensure we are using the internal useI18n hook instead of the useLingui hook from the @lingui/react module.

diff --git a/src/ui/components/context-menu/context-menu-provider.tsx b/src/ui/components/context-menu/context-menu-provider.tsx
@@ -60,7 +60,7 @@ export function ContextMenuProvider({ children }: Props) {
 
   useEffect(() => {
     const wrapper = wrapperRef.current;
-    if (contextMenu === undefined || wrapper === null) {
+    if (wrapper === null) {
       return;
     }
 
@@ -77,13 +77,9 @@ export function ContextMenuProvider({ children }: Props) {
     return () => {
       window.removeEventListener('click', onWindowClick);
     };
-  }, [contextMenu, hideContextMenu]);
+  });
 
   useEffect(() => {
-    if (contextMenu === undefined) {
-      return;
-    }
-
     const onWindowKeyDown = (event: KeyboardEvent) => {
       if (event.key === 'Escape') {
         hideContextMenu();
@@ -95,10 +91,10 @@ export function ContextMenuProvider({ children }: Props) {
     return () => {
       window.removeEventListener('keydown', onWindowKeyDown);
     };
-  }, [contextMenu, hideContextMenu]);
+  });
 
   useLayoutEffect(() => {
-    if (!wrapperRef.current || !contextMenu === undefined) {
+    if (!wrapperRef.current) {
       return;
     }
 
@@ -115,7 +111,7 @@ export function ContextMenuProvider({ children }: Props) {
     }
 
     wrapperRef.current.setAttribute('style', `left: ${x}px; top:${y}px;`);
-  }, [contextMenu]);
+  });
 
   return (
     <ContextMenuContext.Provider

diff --git a/src/ui/demos/use-demos.ts b/src/ui/demos/use-demos.ts
@@ -11,7 +11,7 @@ export function useDemos(): Demo[] {
   const getDemoAnalysisStatus = useGetDemoAnalysisStatus();
   const { analysisStatus } = useDemosSettings();
 
-  if (!analysisStatus === undefined || analysisStatus === AnalysisStatusFilter.All) {
+  if (analysisStatus === AnalysisStatusFilter.All) {
     return demosState.entities;
   }