fix: to handle image.onload event correctly #1723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
image.onload event will be handled by other react-slick instance if there are more than one react-slick instance on the same page.
|
You are right ! I got in same issue and i found same solution after some hours of debugging.... |
akiran
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1356
document.querySelectorAll(".slick-slide img")selector will select all images under.slick-slideand add onload event on those images. if there are multiple react-slick instance on the same page, the image.onload event may be handled by other react-slick instance .This commit aims to fix the issue by searching
".slick-slide img"in the list reference instead of document.