Skip to content

[BUG] non-standard uri fragment #653

@tekumara

Description

@tekumara

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Toggleterm generates uri fragments that contain #, eg:

term://~/code/typos-lsp//59317:/bin/zsh;#toggleterm#1

This causes LSP servers using a strict URI parser to fail in toggleterm. See tower-lsp-community/tower-lsp-server#65.

Expected Behavior

According to RFC 3986 Section 3.5 the use of # in a fragment like toggleterm#1 is non-standard. Lenient parsers may allow this, but strict URI parsers fail.

To allow interoperability with LSP servers that use strict parsers, would you consider an alternative, for example percent encoding (ie: %23) the # in the fragment?

Steps To Reproduce

Use toggleterm with typos-lsp and notice that it doesn't spell check.

Environment

Anything else?

Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions