Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display overriden devicons #817

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: display overriden devicons #817

merged 1 commit into from
Sep 19, 2023

Conversation

scianek
Copy link
Contributor

@scianek scianek commented Sep 18, 2023

pretty much a fix for #191

normally bufferline retrieves the file extension using vim.fn.fnamemodify with the :e option, but that doesn't account for extensions with multiple dots, by passing nil instead of that extension, the inner recursive mechanism of nvim-web-devicons is utilized to get the longest matching extension from the filename

before:
before

after:
after

Copy link
Owner

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

Copy link
Owner

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@akinsho akinsho merged commit 81cd04f into akinsho:main Sep 19, 2023
2 checks passed
sstallion pushed a commit to sstallion/bufferline.nvim that referenced this pull request Jul 3, 2024
normally bufferline retrieves the file extension using vim.fn.fnamemodify with the :e option, but that doesn't account for extensions with multiple dots, by passing nil instead of that extension, the inner recursive mechanism of nvim-web-devicons is utilized to get the longest matching extension from the filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants