Skip to content

Commit

Permalink
fix(utils): update is_list to handle breaking change (#892)
Browse files Browse the repository at this point in the history
  • Loading branch information
@grappas
grappas authored Apr 22, 2024
1 parent f6f00d9 commit a6ad228
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lua/bufferline/utils/init.lua
View file
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,11 @@ end

-- TODO: deprecate this in nvim-0.11 or use strict lists
--- Determine which list-check function to use

if vim.fn.has("nvim-0.10") == 1 then
M.is_list = vim.isarray or vim.islist
else
M.is_list = vim.tbl_isarray or vim.tbl_islist
end

return M

10 comments on commit a6ad228

@Littledarren
Copy link

@Littledarren Littledarren commented on a6ad228 Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have 0.10 but no isarray or islist

@CharlesChiuGit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

OS: macOS
nvim:

NVIM v0.10.0-dev-2560+gf879a6545-Homebrew
Build type: Release
LuaJIT 2.1.1713517273
Run "nvim -V1 -v" for more info

bufferline.nvim commit
"bufferline.nvim": { "branch": "main", "commit": "73540cb95f8d95aa1af3ed57713c6720c78af915" },

@CharlesChiuGit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akinsho @grappas

@akinsho
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Littledarren are you following the latest versions of 0.10. I don't think it's sustainable to try to support within 0.10 I think we have to assume people who follow head do it actively

@akinsho
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also see #893 it's very hard to account for how fast nightly will reach certain people. Someone will hit an issue within an hour and raise an issue as fast as that and someone else might depend on something like the AUR and it'll take them days 🤷🏾‍♂️ I personally don't have the time or bandwidth to try to follow that level of granularity. If you can pin the commit and wait for it to get rolled out to you that would be great

@CharlesChiuGit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, tks!

@Dan7h3x
Copy link

@Dan7h3x Dan7h3x commented on a6ad228 Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_2024-04-22-15-29-39_1920x1080

I've got
NVIM v0.10.0-dev-2786+gb3f9da952
Build type: RelWithDebInfo
LuaJIT 2.1.1710088188
Run "nvim -V1 -v" for more info

and have this issue
Linux

Actually i've updated neovim and its fixed

@grappas
Copy link
Contributor Author

@grappas grappas commented on a6ad228 Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guys - just compile latest neovim build.

something like the AUR and it'll take them days

I'm building from AUR https://aur.archlinux.org/packages/neovim-git
Keep in mind that if you using AUR helper (like yay or paru) to pull latest repo from *-git package you have to a) manually mark it to install or b) upgrade packages with --devel flag so that helper would force check commit status of the packages.

obraz

AUR *-git packages are rarely if ever bumping versions. Without --devel flag it will never upgrade.

@nopears
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same issue with neovim's 0.10 version :(

@ipChrisLee
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_2024-04-22-15-29-39_1920x1080

I've got NVIM v0.10.0-dev-2786+gb3f9da952 Build type: RelWithDebInfo LuaJIT 2.1.1710088188 Run "nvim -V1 -v" for more info

and have this issue Linux

Actually i've updated neovim and its fixed

Upgrade neovim fixed this issue in ubuntu-22.04

Please sign in to comment.