Skip to content

Commit

Permalink
Remove denoise module and thirdparty OIDN
Browse files Browse the repository at this point in the history
This is replaced by a much lighter weight and faster JNLM denoiser.

OIDN is still much more accurate, and may be provided as an optional backend
in the future, but the JNLM denoiser seems good enough for most use cases and
remove OIDN reduces the buildsystem complexity, binary size, and build times
for Godot very significantly.
  • Loading branch information
akien-mga committed Sep 18, 2023
1 parent e3e2528 commit 9412222
Show file tree
Hide file tree
Showing 326 changed files with 0 additions and 114,457 deletions.
5 changes: 0 additions & 5 deletions COPYRIGHT.txt
Original file line number Diff line number Diff line change
Expand Up @@ -408,11 +408,6 @@ Comment: Stripped down version of "nvapi.h" from the NVIDIA NVAPI SDK
Copyright: 2019-2022, NVIDIA Corporation
License: Expat

Files: ./thirdparty/oidn/
Comment: Intel Open Image Denoise
Copyright: 2009-2019, Intel Corporation
License: Apache-2.0

Files: ./thirdparty/openxr/
Comment: OpenXR Loader
Copyright: 2020-2023, The Khronos Group Inc.
Expand Down
1 change: 0 additions & 1 deletion doc/classes/LightmapGI.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
</member>
<member name="use_denoiser" type="bool" setter="set_use_denoiser" getter="is_using_denoiser" default="true">
If [code]true[/code], uses a CPU-based denoising algorithm on the generated lightmap. This eliminates most noise within the generated lightmap at the cost of longer bake times. File sizes are generally not impacted significantly by the use of a denoiser, although lossless compression may do a better job at compressing a denoised image.
[b]Note:[/b] The built-in denoiser (OpenImageDenoise) may crash when denoising lightmaps in large scenes. If you encounter a crash at the end of lightmap baking, try disabling [member use_denoiser].
</member>
</members>
<constants>
Expand Down
138 changes: 0 additions & 138 deletions modules/denoise/SCsub

This file was deleted.

12 changes: 0 additions & 12 deletions modules/denoise/config.py

This file was deleted.

66 changes: 0 additions & 66 deletions modules/denoise/denoise_wrapper.cpp

This file was deleted.

38 changes: 0 additions & 38 deletions modules/denoise/denoise_wrapper.h

This file was deleted.

65 changes: 0 additions & 65 deletions modules/denoise/lightmap_denoiser.cpp

This file was deleted.

Loading

0 comments on commit 9412222

Please sign in to comment.