Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update SDK to v0.43.0 and add upgrade handler #1262

Closed
wants to merge 15 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
akhilkumarpilli committed May 27, 2021
commit 169717150649de3eb60eb6e7268fab5aafe36d8a
4 changes: 3 additions & 1 deletion client/broadcaster/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import (
var (
// ErrBroadcastTx is used when a broadcast fails due to tendermint errors
ErrBroadcastTx = errors.New("broadcast tx error")
// ErrSimulateTx is used when unsigned tx is not proto tx provider format
ErrSimulateTx = errors.New("cannot simulate amino tx")
)

type Client interface {
Expand Down Expand Up @@ -162,7 +164,7 @@ func BuildSimTx(txf tx.Factory, msgs ...sdk.Msg) ([]byte, error) {

protoProvider, ok := txb.(protoTxProvider)
if !ok {
return nil, fmt.Errorf("cannot simulate amino tx")
return nil, fmt.Errorf("%w: not protoTxProvider format", ErrSimulateTx)
}
simReq := txtypes.SimulateRequest{Tx: protoProvider.GetProtoTx()}

Expand Down
5 changes: 3 additions & 2 deletions x/cert/keeper/key.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ import (
"math/big"

sdk "github.com/cosmos/cosmos-sdk/types"
sdkAddress "github.com/cosmos/cosmos-sdk/types/address"
"github.com/ovrclk/akash/x/cert/types"
)

const (
keyAddrPrefixLen = 1 + sdkAddress.MaxAddrLen
// AddrLen defines a valid address length
AddrLen = 20
keyAddrPrefixLen = 1 + AddrLen
)

var (
Expand Down