Skip to content

Commit

Permalink
Updated PR template, stale and codecov settings (cosmos#5362)
Browse files Browse the repository at this point in the history
* updated PR template, stale and codecov settings

* remove extra line

* address @alexanderbez comments

* Update .codecov.yml
  • Loading branch information
fedekunze authored Dec 4, 2019
1 parent 202cb9b commit 12ff486
Show file tree
Hide file tree
Showing 3 changed files with 54 additions and 16 deletions.
34 changes: 29 additions & 5 deletions .codecov.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

#
# This codecov.yml is the default configuration for
# all repositories on Codecov. You may adjust the settings
Expand All @@ -10,18 +9,43 @@ coverage:
range: 70...100

status:
# Learn more at https://codecov.io/docs#yaml_default_commit_status
project:
# Learn more at https://docs.codecov.io/docs/commit-status
project:
default:
threshold: 1% # allow this much decrease on project
app:
target: 70%
flags: app
modules:
target: 70%
flags: modules
client:
flags: client
changes: false

comment:
layout: "header, diff"
behavior: default # update if exists else create new
layout: "reach, diff, files"
behavior: default # update if exists else create new
require_changes: true

flags:
app:
paths:
- "app/"
- "baseapp/"
modules:
paths:
- "x/"
- "!x/**/client/" # ignore client package
client:
paths:
- "client/"
- "x/**/client/"

ignore:
- "docs"
- "*.md"
- "*.rst"
- "x/**/test_common.go"
- "scripts/"
- "contrib"
32 changes: 23 additions & 9 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,31 @@ v Before smashing the submit button please review the checkboxes.
v If a checkbox is n/a - please still include it but + a little note why
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->

- Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/develop/CONTRIBUTING.md#pr-targeting))
Closes: #XXX

- [ ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Wrote tests
- [ ] Updated relevant documentation (`docs/`)
## Description

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review.
-->

______

For contributor use:

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the github PR explorer
- [ ] Re-reviewed `Files changed` in the Github PR explorer

______

For Admin Use:
- Added appropriate labels to PR (ex. wip, ready-for-review, docs)
- Reviewers Assigned
- Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
For admin use:

- [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc)
- [ ] Reviewers assigned
- [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
4 changes: 2 additions & 2 deletions .github/stale.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Configuration for probot-stale - https://github.com/probot/stale

# Number of days of inactivity before an Issue or Pull Request becomes stale
daysUntilStale: 60
daysUntilStale: 10

# Number of days of inactivity before an Issue or Pull Request with the stale label is closed.
# Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale.
daysUntilClose: 9
daysUntilClose: 4

# Only issues or pull requests with all of these labels are check if stale. Defaults to `[]` (disabled)
onlyLabels: []
Expand Down

0 comments on commit 12ff486

Please sign in to comment.