feat(ts): add essential exports by versions (#184) #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a more streamlined approach to managing and exporting Akash protobuf files across various projects. By centralizing exports, I aim to reduce code duplication and improve maintainability across the ecosystem.
Key Changes
akash-api
repository. This change allows other projects (like Cloudmos API, Indexer, and Deploy-Web) to utilize a single source of truth instead of maintaining duplicated code across different repositories.Current Differences and Impact
I've identified slight variations in the proto files used across different projects:
Storage
import.GPU
import not present in other versions.DepositDeploymentAuthorization
import.Question for Review
Is the presence of these unique imports intended, or should the proto files be uniform across all versions and projects? Understanding this will guide whether I can safely replace the duplicated files with centralized exports from the
akash-api
.Proposal
Assuming these differences are not required for specific functional needs, my proposal is to eliminate all duplicate proto files in favor of those exported from the
akash-api
. This would simplify the codebase and ensure consistency.