Skip to content

Commit

Permalink
chore(dev): Clean up main tsconfigs (getsentry#5114)
Browse files Browse the repository at this point in the history
This does some clean up work on our two main tsconfig files, in `@sentry/typescript` and at the root level of our repo. Included changes:
	- Removed `pretty` - what we had is the default
	- Removed `noImplicitAny` and `noImplicitThis` - implied by `strict: true`
	- Turned off emitting types files, as we now do this separately
	- Moved `noErrorTruncation` up to the typescript package, so that anyone (is there anyone besides us?) using it gets the benefit of actually being able to see full errors
  • Loading branch information
lobsterkatie authored and AbhiPrasad committed May 30, 2022
1 parent bcce71b commit fc5641e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
5 changes: 1 addition & 4 deletions packages/typescript/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,15 @@
"inlineSources": true,
"isolatedModules": true,
"lib": ["es6", "dom"],
// "module": "commonjs", // implied by "target" : "es5"
"moduleResolution": "node",
"noEmitHelpers": true,
"noErrorTruncation": true,
"noFallthroughCasesInSwitch": true,
"noImplicitAny": true,
"noImplicitReturns": true,
"noImplicitThis": true,
"noImplicitUseStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"preserveWatchOutput": true,
"pretty": true,
"sourceMap": true,
"strict": true,
"strictBindCallApply": false,
Expand Down
7 changes: 2 additions & 5 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,9 @@
"extends": "./packages/typescript/tsconfig.json",

"compilerOptions": {
// TODO: turn these on once we switch to only generating types once, using `tsconfig.types.json`
// "declaration": false,
// "declarationMap": false,

"allowSyntheticDefaultImports": true,
"declaration": false,
"declarationMap": false,
"types": ["node"],
"noErrorTruncation": true // move me up to @sentry/typescript
}
}

0 comments on commit fc5641e

Please sign in to comment.