feat: update effect deps so unfavorited emails are removed

This commit updates the handlFavoriteButtonClick to only have dependencies on the filter and the filteredEmails so that when a user unfavorites an email, that email is removed from the favorites list immediately
ajyey · Jun 24, 2023 · 1c6aa4f · 1c6aa4f
1 parent 0410a6e
commit 1c6aa4f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/pages/popup/components/home/detail/EditButton.tsx b/src/pages/popup/components/home/detail/EditButton.tsx
@@ -1,6 +1,5 @@
 import React from 'react';
 import { EditIcon } from '@pages/popup/components/home/icons/icons';
-import handleFavoriteButtonClick from '@pages/popup/components/home/detail/EmailDetailPane';
 
 interface EditButtonProps {
   onClick: () => void;

diff --git a/src/pages/popup/components/home/emails/EmailList.tsx b/src/pages/popup/components/home/emails/EmailList.tsx
@@ -43,7 +43,7 @@ function EmailList({
       setFilteredEmails(newFilteredEmails);
     };
     applyFilter();
-  }, [maskedEmails, filter]);
+  }, [filter, filteredEmails]);
 
   // Use Fuse.js to perform the fuzzy search
   const fuse: Fuse<MaskedEmail> = new Fuse(filteredEmails, {